json parsing improvements & fixes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
changed the title
|
added a fix, but it's non-trivial as we have to manage a bit more state than just "what's next?" in a stack - the "have we done the first one?" needs to be preserved across stack frames will do some testing with more round-trips using ipld-garbage to see if this breaks anywhere interesting where it shouldn't |
|
(lgtm) |
rvagg
added a commit
to ipld/go-ipld-prime
that referenced
this pull request
Sep 26, 2023
To confirm that new refmt JSON decoding changes don't raise any red flags Ref: polydawn/refmt#58
willscott
approved these changes
Sep 26, 2023
|
ipld/go-ipld-prime#550 looks good, I feel more confident about these changes now |
rvagg
added a commit
to ipld/go-ipld-prime
that referenced
this pull request
Sep 26, 2023
To confirm that new refmt JSON decoding changes don't raise any red flags Ref: polydawn/refmt#58
3 tasks
|
Per @rvagg 's nudge in another channel that you're happy with this now -- I'm also perfectly happy to merge this, and thank you :) |
rvagg
added a commit
to ipld/go-ipld-prime
that referenced
this pull request
Dec 11, 2023
To confirm that new refmt JSON decoding changes don't raise any red flags Ref: polydawn/refmt#58
rvagg
added a commit
to ipld/go-ipld-prime
that referenced
this pull request
Dec 11, 2023
To confirm that new refmt JSON decoding changes don't raise any red flags Ref: polydawn/refmt#58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a fix, it's just a placeholder (demonstration) of some cases that should fail that don't and some that fail with errors messages that are inappropriate. Posting this here while I notice it, perhaps I'll come back and fix soon!More tests added; fixes applied; more comprehensive testing done via ipld/go-ipld-prime#550